瀏覽代碼

refactor(waf): 移除更新数据库记录函数的冗余参数

- 修改了 UpdateDatabaseRecords函数,移除了未使用的 oldData 参数
- 更新了相关调用,减少了不必要的参数传递
-优化了代码结构,提高了函数的可读性和可维护性
fusu 1 天之前
父節點
當前提交
97d75fd3d3
共有 2 個文件被更改,包括 4 次插入4 次删除
  1. 3 3
      internal/service/api/waf/aidedweb.go
  2. 1 1
      internal/service/api/waf/webforwarding.go

+ 3 - 3
internal/service/api/waf/aidedweb.go

@@ -44,7 +44,7 @@ type AidedWebService interface {
 	
 	// 数据库操作
 	SaveToDatabase(ctx context.Context, req *v1.WebForwardingRequest, require RequireResponse, webId int64, cdnOriginIds map[string]int64) (int, error)
-	UpdateDatabaseRecords(ctx context.Context, req *v1.WebForwardingRequest, oldData *model.WebForwarding, require RequireResponse, ipData *model.WebForwardingRule) error
+	UpdateDatabaseRecords(ctx context.Context, req *v1.WebForwardingRequest, require RequireResponse, ipData *model.WebForwardingRule) error
 	CleanupDatabaseRecords(ctx context.Context, id int) error
 	
 	// SSL证书管理
@@ -386,7 +386,7 @@ func (s *aidedWebService) WashDifferentIp(newIpList []string, oldIpList []string
 			newAllowIps = append(newAllowIps, v)
 		}
 	}
-	
+
 	addedDenyIps, removedDenyIps = s.wafformatter.findIpDifferences(oldAllowIps, newAllowIps)
 	return addedDenyIps, removedDenyIps
 }
@@ -1027,7 +1027,7 @@ func (s *aidedWebService) SaveToDatabase(ctx context.Context, req *v1.WebForward
 }
 
 // UpdateDatabaseRecords 更新数据库记录
-func (s *aidedWebService) UpdateDatabaseRecords(ctx context.Context, req *v1.WebForwardingRequest, oldData *model.WebForwarding, require RequireResponse, ipData *model.WebForwardingRule) error {
+func (s *aidedWebService) UpdateDatabaseRecords(ctx context.Context, req *v1.WebForwardingRequest, require RequireResponse, ipData *model.WebForwardingRule) error {
 	webModel := s.BuildWebForwardingModel(&req.WebForwardingData, req.WebForwardingData.CdnWebId, require)
 	webModel.Id = req.WebForwardingData.Id
 

+ 1 - 1
internal/service/api/waf/webforwarding.go

@@ -277,7 +277,7 @@ func (s *webForwardingService) EditWebForwarding(ctx context.Context, req *v1.We
 	}
 
 	// 11. 更新本地数据库记录
-	if err := s.aidedWeb.UpdateDatabaseRecords(ctx, req, oldData, require, ipData); err != nil {
+	if err := s.aidedWeb.UpdateDatabaseRecords(ctx, req, require, ipData); err != nil {
 		return err
 	}