Browse Source

refactor(webforwarding): 优化删除域白名单逻辑

- 提取获取 IP 地址的逻辑到 GetIp 方法中
-优化错误处理,确保在获取 IP 失败时正确返回错误- 重用 IP 变量,提高代码可读性
fusu 1 month ago
parent
commit
de7407b7f1
1 changed files with 5 additions and 5 deletions
  1. 5 5
      internal/service/webforwarding.go

+ 5 - 5
internal/service/webforwarding.go

@@ -419,17 +419,17 @@ func (s *webForwardingService) DeleteWebForwarding(ctx context.Context, Ids []in
 		webData, err := s.webForwardingRepository.GetWebForwarding(ctx, int64(Id))
 		if err != nil {
 			return err
-		}
-		Ip, err := s.gatewayGroupIpRep.GetGateWayGroupFirstIpByGatewayGroupId(ctx, webData.WafGatewayGroupId)
-		if err != nil {
-
 		}
 		if webData.Domain != "" {
+			ip , err := s.GetIp(ctx, webData.WafGatewayGroupId)
+			if err != nil {
+				return err
+			}
 			doMain, err := s.wafformatter.ConvertToWildcardDomain(ctx, webData.Domain)
 			if err != nil {
 				return err
 			}
-			go s.publishDomainWhitelistTask(doMain,Ip, "del")
+			go s.publishDomainWhitelistTask(doMain,ip, "del")
 		}
 		_, err = s.crawler.DeleteRule(ctx, wafWebId, "admin/delete/waf_web?page=1&__pageSize=10&__sort=waf_web_id&__sort_type=desc")
 		if err != nil {